Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set URL to Faktory instance via FAKTORY_URL env variable #4

Merged
merged 1 commit into from
May 13, 2020
Merged

Allow to set URL to Faktory instance via FAKTORY_URL env variable #4

merged 1 commit into from
May 13, 2020

Conversation

Envek
Copy link
Contributor

@Envek Envek commented May 13, 2020

Duplicated from praekeltfoundation#3

Context

In containerized world (especially in Kubernetes) it is very common pattern to pass secret values via environment variables without exposing them in command line arguments or elsewhere.

What's inside

Ability to specify URL to faktory instance (including password) via FAKTORY_URL environment variable.

Kubernetes usage

Example of defining sidecar with exporter for Faktory server pod (see AdWerx/charts#12 for real example of usage)

# Somewhere deep in StatefulSet declaration
        - name: metrics-exporter
          image: "praekeltfoundation/faktory_exporter:notyetreleased"
          imagePullPolicy: Always
          env:
            - name: FAKTORY_PASSWORD
              valueFrom:
                secretKeyRef:
                  name: faktory
                  key: password
            - name: FAKTORY_URL
              value: tcp://:$(FAKTORY_PASSWORD)@localhost:7419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants