Cache SID result

[dsawardekar]

@luke-gru I recently added Profiling support to Speckle. While profiling my extensions I noticed that the SID function that Riml generates is executed a very large number of times. In Portkey this is most apparent with something like 30,000+ calls. The function itself is quite fast. Since the SID doesn't change I'd like to cache this out if possible.

I'm thinking something like a SID_VALUE that holds the result with a function like below,

function! s:SID()
  if exists('s:SID_VALUE')
    return s:SID_VALUE
  endif

  let s:SID_VALUE = matchstr(expand('<sfile>'), '<SNR>\zs\d\+\ze_SID$')

  return s:SID_VALUE
endfunction

[luke-gru]

Good idea! I just pushed a new version, 0.3.5, that includes this fix, along with several compiler speed-ups too. I ran portkey's vim tests, and they do run a couple of seconds faster on my computer, so it looks like caching the SID is paying off a lot 👍

In 0.3.5, there's also file rollback support that's explained in the CHANGELOG.

I'm planning on doing the smarter riml_include stuff now.

Thanks again!

[dsawardekar]

That was quick. Thanks!

Rollback looks interesting. Although I rarely use riml_source. My workflow is to create 2 target files. plugin.vim and app.vim. Where app.vim is autoloaded with a viml call like my_plugin#app() which bootstraps the app and returns a reference to it.

I don't break the plugin/app into multiple vim targets. I find that this is more of an organizational thing that traditional viml plugins use. But with Riml there is already good organization by classes and objects in their own files.