Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize non-external HTML assets with publicPath value #14

Closed
lukeed opened this issue Nov 20, 2020 · 0 comments
Closed

Synchronize non-external HTML assets with publicPath value #14

lukeed opened this issue Nov 20, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@lukeed
Copy link
Owner

lukeed commented Nov 20, 2020

As part of the HTML build step, look at any asset path that is not ^(https?:)?\/\/ and update it so that it's led with the desired publicPath prefix.

Safe to do with asset paths like href="/styles.css"" since that's assuming root-resolver.
Less safe to manipulate href="styles.css" since that may need to be a location-based resolver, but I think it's okay for freshie to say that, as the root HTML template, it should only be absolute URLs... since that template is/can be used to render any page.


Related: lukeed/svelte-ssr-worker#2 (comment)

@lukeed lukeed added the bug Something isn't working label Nov 20, 2020
@lukeed lukeed closed this as completed in 670eb70 Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant