Incorrect typing in worktop/ws

[dhrubabasu]

This code:

import type {Handler} from 'worktop';
import {connect} from 'worktop/ws';

export const handler: Handler = async (request) => {
  const error = connect(request);
  if (error) return error;
};

produces the following Eslint errors:

  ✖    5:17  Unsafe call of an any typed value.                                   @typescript-eslint/no-unsafe-call
  ✖    6:14  Unsafe return of an any typed value.                                 @typescript-eslint/no-unsafe-return

[lukeed]

Sorry, I do not care the slightest about eslint. If you know exactly what it's complaining about I can look at fixing it, but I'm not going to investigate otherwise. Eslint is replaced by tsc directly -- at least for errors like this.

[dhrubabasu]

It's complaining about this: https://github.com/lukeed/worktop/blob/master/src/ws.d.ts#L47

Eslint reads connect with type any:

[lukeed]

On your end, can you try this for the types file:

declare const connect: Handler;
export { connect };

[dhrubabasu]

Oh, that file doesn't have import type { Handler } from 'worktop'; at the top. Adding that fixes the issue on my end. I did have to modify the handler to this:

export const handler: Handler = async (request, response) => {
  const error = await connect(request, response);
  if (error) return error;
}

Not a huge deal but could be a good idea to modify the connect type declaration to only require the request parameter as it does nothing with the response.