Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password regex limitations #13

Closed
damianstasik opened this issue Nov 29, 2016 · 3 comments
Closed

Password regex limitations #13

damianstasik opened this issue Nov 29, 2016 · 3 comments

Comments

@damianstasik
Copy link

It should allow the user to type in whatever he/she wants. Why? Because they might be using password generators and this regex:

/^[a-zA-Z0-9+_-]{6,18}$/

... is limiting them to use only a small subset of characters and that is not a good practice. I think it should also allow to type in longer text, instead of 18, I would use for example 32.

@lukehaas
Copy link
Owner

Thanks, you're right, I've been intending to make this more flexible.

@RobThree
Copy link

RobThree commented Nov 29, 2016

What about !@#$%^&*()={};:'"<>,./\?~ or space, or 💩 or ☃? Why restrict a password to anything at all (maybe just a lower limit on length...)

@lukehaas
Copy link
Owner

Password regex is now removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants