You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Resize down the browser window. Greedy nav starts to correctly hide items
Once several items are hidden, maximize the browser window.
Expected behavior:
All items in the navigation bar are now correctly displayed, as the window is maximized.
Actual behavior:
The navbar seems to update at some intermediary state, as only part of the navigation items are visible after the window was maximized, while others are still hidden.
Screenshot (1080x1920 monitor, full screen):
I assume it happens because the resize listener fires off in a weird way when a maximize is being performed, however I'm not a web dev so I don't know how to fix it myself in order to submit a pull request.
Kind regards,
CataJ
The text was updated successfully, but these errors were encountered:
There is a recursive call missing. After removing an element check() is called to check if more elements need to be removed. After adding an element this is not happening.
Add check(); in greedynav.js after L41 and it works.
Hello,
Great project!
I noticed one issue though, and maybe it would be easier to explain it by just mentioning how to reproduce it:
Expected behavior:
All items in the navigation bar are now correctly displayed, as the window is maximized.
Actual behavior:
The navbar seems to update at some intermediary state, as only part of the navigation items are visible after the window was maximized, while others are still hidden.
Screenshot (1080x1920 monitor, full screen):
I assume it happens because the resize listener fires off in a weird way when a maximize is being performed, however I'm not a web dev so I don't know how to fix it myself in order to submit a pull request.
Kind regards,
CataJ
The text was updated successfully, but these errors were encountered: