feat: customization options #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added configure and login otp pages
[pages] Add Login OTP
Hi, Thanks for your nice project! I learned a lot of it! I saw that you don't apply breaks in the switch. This is necessary. check: https://freemarker.apache.org/docs/ref_directive_switch.html
Hi, An HTML tag issue.
[pages] Fix Register
[pages] Fix Logout
Fix a typo
[pages] Add Recovery Codes and WebAuthn
|
if this pr gets merged, i would also introduce our gdpr/ccpa compliant solution for the footer: (or in germany: dsgvo)
customization options, could also be usefull for the logo within the comming email theme, to dont require the user to change it within the file. |
|
@lukin thanks for updating the PR. Happy to hear, such feature is wanted? If you interested, I can also add the footer thing mentioned above. Displayed with plain if statements. Do you know a better option to may use and/or extend localization? |
|
closed in favor for: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey folks,
while developing this theme suiteable for our company, we had address some minor responsive issues and placed a background video + our own logo at the top-left corner. which looks quite neat.😇
as this could be a good additional option to customize the theme easily i would like to introduce a customization behavior by the theme.properties file, so anyone can just paste theire sources in and are good to go.
@lukin is this something you would like to see or would such behaviors be to tough to support in the future? if this is not wanted for the future, its ok if you just close the PR. <3
LOGO.mp4