Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support workflow presets #102

Closed
quyykk opened this issue Feb 1, 2023 · 3 comments
Closed

Support workflow presets #102

quyykk opened this issue Feb 1, 2023 · 3 comments

Comments

@quyykk
Copy link

quyykk commented Feb 1, 2023

CMake 3.25 adds a new preset, the workflow preset, which is very useful in CI because it describes an arbitrary sequence of build and test (and package) presets.

Thanks!

@lukka
Copy link
Owner

lukka commented Feb 4, 2023

@quyykk how do you think this should work for run-cmake?

  1. One way would be to add a new input called workflowPreset, a string, which when it's set, the action runs cmake --workflow --preset <name>.
  2. When workflowPreset is set, the buildPreset and configurePreset inputs are disregarded (with a warning message).
  3. Is a workflowPresetAdditionalArgs input useful?

Any input is appreciated, thanks!

@quyykk
Copy link
Author

quyykk commented Feb 4, 2023

One way would be to add a new input called workflowPreset, a string, which when it's set, the action runs cmake --workflow --preset <name>.

yeah. Does it makes sense to pass --fresh as well (it cleans any build files)?

When workflowPreset is set, the buildPreset and configurePreset inputs are disregarded (with a warning message).

makes sense

Is a workflowPresetAdditionalArgs input useful?

The only potential argument to pass is --fresh, so probably not?

@lukka
Copy link
Owner

lukka commented Feb 5, 2023

@quyykk solved in https://github.com/lukka/run-cmake/releases/tag/v10.3, let me know if this works for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants