Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UP Ext] Do not require full url for SIWE #19

Open
lykhonis opened this issue Nov 15, 2022 · 1 comment
Open

[UP Ext] Do not require full url for SIWE #19

lykhonis opened this issue Nov 15, 2022 · 1 comment
Labels
enhancement New feature or request extension Issues related to the UP browser extension

Comments

@lykhonis
Copy link

Is your feature request related to a problem? Please describe.
When logging in using SIWE UP extension verifies current full url in browser window vs just domain. This makes it hard to track down all possible pages of an app where SIWE may be required.

Describe the solution you'd like
Do not require / verify full url, instead verify host/origin.

Describe alternatives you've considered
Tracking down each page and placing the url from the page into SIWE form data

Additional context
How it looks when URL matches
Screen Shot 2022-11-14 at 19 33 45
How it looks when URL has same host/origin but different path
Screen Shot 2022-11-14 at 19 34 58

@lykhonis lykhonis added enhancement New feature or request extension Issues related to the UP browser extension labels Nov 15, 2022
@dzbo
Copy link
Collaborator

dzbo commented Nov 15, 2022

@Hugoo Hugoo changed the title [Web UP Extension] Do not require full url for SIWE [UP Ext] Do not require full url for SIWE Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request extension Issues related to the UP browser extension
Development

No branches or pull requests

2 participants