Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Potentially Remove csslint #74

Closed
carwin opened this issue Jan 11, 2016 · 3 comments
Closed

Potentially Remove csslint #74

carwin opened this issue Jan 11, 2016 · 3 comments

Comments

@carwin
Copy link
Contributor

carwin commented Jan 11, 2016

I don't see a reason to lint compiled code and I misunderstood what was happening when I merged the code. Discuss.

@krisbulman
Copy link
Contributor

i vote either removing it completely, or replacing with scss-lint (ruby dep). if scss-lint is added to a test command in grunt, only run it if you want to, and have your ci tool run it if you want to.

@wesruv
Copy link
Contributor

wesruv commented May 25, 2016

Late to the party, it's worth trying out the node sass-linter is awesome: https://www.npmjs.com/package/sass-lint

Looks like they've been cranking on it, but I haven't tried it.

If not I vote scss-lint.

If we're not writing a compiler, I don't see why we'd lint CSS. If there's a feature missing from our SCSS/Sass linter, we should try to help fix it there.

carwin added a commit that referenced this issue May 25, 2016
carwin added a commit that referenced this issue May 25, 2016
Issue #74: Removes  csslint from the 8.x branch.
carwin added a commit that referenced this issue May 25, 2016
Issue #74: Removes `csslint` from the 7.x master branch.
@carwin
Copy link
Contributor Author

carwin commented May 25, 2016

For now I've just removed it. I want to avoid using scss-lint because of the Ruby dependency. If sass-lint turns out to be acceptable, we'll put that in. For now let's leave linting on a case-by-case basis until we discover something we can all get behind.

@carwin carwin closed this as completed May 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants