Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is bourbon included with a relative path #242

Closed
charandas opened this issue Apr 9, 2015 · 3 comments
Closed

Why is bourbon included with a relative path #242

charandas opened this issue Apr 9, 2015 · 3 comments

Comments

@charandas
Copy link

Like so, from the dist:

https://github.com/lumapps/lumX/blob/v0.3.25/dist/scss/_lumx.scss#L5

@import "../../../bourbon/app/assets/stylesheets/bourbon";

In my case, my 3rd party dependencies are being installed through jspm and they end up not being on a flat path, instead based on the github org path:

dependencies\thoughtbot\bourbon\...
depedencies\lumapps\lumX\dist\...

It would be nice if it was just:

@import 'bourbon'

Then in my use case, I could use your sass preprocessing includePaths option to provide the bourbon path detail. Thoughts?

@malexandre
Copy link
Contributor

Hi!

I'll try to have a look at this and get back to you soon.

@malexandre
Copy link
Contributor

I've managed it. I'll need to update the documentations because now everyone will need to manage the include path manually. I won't make the release today though.

@charandas
Copy link
Author

Thanks. Keep up the good work! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants