Dynamic dolly speed/rotation sensitivity #249
Conversation
| untrack(() => (cam.position.z = this.scrollFling!.y)) | ||
| const setScrollFactor = this.dynamicDolly | ||
| untrack(() => { | ||
| cam.position.z = this.scrollFling!.y |
There was a problem hiding this comment.
The untrack could also be untrack(() => cam.position).z =. There is an infinite loop here (not sure if you noticed that, without untrack).
This is one thing that needs to be fixed. It was based on an older pattern when things were all event based, and sub props (x/y/z) made the parent object emit an event (I basically ported it verbatim to Solid reactivity). In this case setting .z triggers reactivity for .position, which triggers the same effect we're setting the value in.
I think either we can remove reactivity for .position (and .rotation, etc) and have only the x/y/z properties be reactive, or have .position (etc) be Solid mutables (return createMutable(this) in XYZValues). The thing is, this is currently possible: el1.position = el2.position, and would no longer work. Hmmm
-Removed excess rotation after mouse is idle for >100ms
-Removed excess rotation after mouse is idle for >100ms
…erations, and rename variables to reduce ambiguity and have matching pattern in naming
naming updates, math re-ordering
keywizzle
force-pushed
the
dynamic-camera-rig
branch
from
81901e2
to
c177d4b
Compare
|
Closing in favor of the other PR with the branch inside our repo: #251 |
-Removed excess rotation after mouse is idle for >100ms