Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always print errors with stack #117

Merged
merged 3 commits into from
Jun 25, 2021
Merged

Always print errors with stack #117

merged 3 commits into from
Jun 25, 2021

Conversation

fserb
Copy link
Contributor

@fserb fserb commented Jun 24, 2021

This addresses bug #116

oscarotero
oscarotero requested changes Jun 24, 2021
View reviewed changes
cli/utils.js Show resolved Hide resolved
@fserb
Copy link
Contributor Author

fserb commented Jun 24, 2021

Updated with:

  • merged printError and printErrorData
  • output: message, vars, stack
  • the sub-exceptions only show the new stack lines, which makes the sub-exceptions more clear.

@oscarotero
Copy link
Member

Awesome job. Thank you!

@oscarotero oscarotero merged commit 4c4c099 into lumeland:master Jun 25, 2021
@fserb fserb deleted the error branch June 27, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscarotero oscarotero oscarotero requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fserb @oscarotero