Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline plugin generates invalid javascript #192

Merged
merged 4 commits into from
Apr 26, 2022

Conversation

kuboon
Copy link
Contributor

@kuboon kuboon commented Apr 26, 2022

element.innerHTML = await getContent(path);

This code causes unexpected html escaping like > => >

I'm trying to write test.

```javascript
element.innerHTML = await getContent(path);
```
This code causes unexpected html escaping like `>` => `>`
@oscarotero
Copy link
Member

Nice, thanks!
To create a test, you can edit the script.js file here https://github.com/lumeland/lume/tree/master/tests/assets/inline adding a arrow function, for example. Then you can update the tests with deno task test:update.

@kuboon
Copy link
Contributor Author

kuboon commented Apr 26, 2022

ok, I'll try.

@kuboon
Copy link
Contributor Author

kuboon commented Apr 26, 2022

Should I change this test name?
https://github.com/lumeland/lume/blob/master/tests/inline.test.ts#L5

@oscarotero
Copy link
Member

Yes, please.
thanks!

@kuboon
Copy link
Contributor Author

kuboon commented Apr 26, 2022

done!

@oscarotero oscarotero marked this pull request as ready for review April 26, 2022 12:55
@oscarotero oscarotero merged commit 38b48cd into lumeland:master Apr 26, 2022
@oscarotero
Copy link
Member

Merged. Thank you!

@kuboon kuboon deleted the patch-1 branch April 26, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants