Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore deno.jsonc #209

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Ignore deno.jsonc #209

merged 1 commit into from
Jul 4, 2022

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Jul 4, 2022

Per https://deno.land/manual/getting_started/configuration_file, Deno config file can also use deno.jsonc as filename.

mod.ts Show resolved Hide resolved
@oscarotero
Copy link
Member

Thanks @kidonng , I didn't add it because .jsonc files are not loaded by default (and Lume only support deno.json file). But it's good idea to ignore it anyway.

Before merging, could you fix the tests?

@oscarotero
Copy link
Member

Never mind. I'm merging it anyway because once removed .ignore((path) => path.endsWith("/.DS_Store")) tests will pass again.

@oscarotero oscarotero merged commit 6c3ebea into lumeland:master Jul 4, 2022
@kidonng
Copy link
Contributor Author

kidonng commented Aug 7, 2022

I didn't add it because .jsonc files are not loaded by default (and Lume only support deno.json file)

Ah, I just realized this. I think it makes sense to add support for loading it, but not modifying it via lume import-map which can be too much a hassle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants