Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expires middleware should ignore the charset #233

Closed
oscarotero opened this issue Aug 11, 2022 · 0 comments
Closed

expires middleware should ignore the charset #233

oscarotero opened this issue Aug 11, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
1.10.3

Comments

@oscarotero
Copy link
Member

If the content type is text/html; charset=UTF-8, the charset should be ignored in order to find the correct duration value here: https://github.com/lumeland/lume/blob/master/middlewares/expires.ts#L18
@oscarotero oscarotero added bug Something isn't working good first issue Good for newcomers labels Aug 11, 2022
@oscarotero oscarotero modified the milestones: 1.11.0, 1.10.3 Aug 11, 2022
@oscarotero oscarotero changed the title expires header should ignore the charset expires middleware should ignore the charset Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
1.10.3
Development

No branches or pull requests
1 participant
@oscarotero