Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate --dev mode #244

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Deprecate --dev mode #244

merged 2 commits into from
Jul 17, 2023

Conversation

denizdogan
Copy link
Contributor

Fixes #201.

Note sure if you wanted to just remove it or add some sort of deprecation warning. I just removed it here.

@oscarotero
Copy link
Member

Thanks, it's great!
This was an idea for Lume 2.0 (because it's a breaking change). I don't plan to release a mayor version soon, so I'm going to leave it unmerged for now.

@denizdogan denizdogan force-pushed the denizdogan/deprecate-dev-mode branch from 6259d6b to b1d381a Compare August 26, 2022 10:05
@oscarotero oscarotero mentioned this pull request Sep 13, 2022
Closed
@oscarotero oscarotero changed the base branch from master to v2 July 17, 2023 22:09
@oscarotero oscarotero added this to the 2.0.0 milestone Jul 17, 2023
@oscarotero oscarotero merged commit c1db721 into lumeland:v2 Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Deprecate --dev mode.
2 participants
@denizdogan @oscarotero