Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFF Plugin #529

Merged
merged 16 commits into from
Jan 22, 2024
Merged

FFF Plugin #529

merged 16 commits into from
Jan 22, 2024

Conversation

kwaa
Copy link
Member

@kwaa kwaa commented Dec 15, 2023

Description

This plugin provides types and transform features for FFF Flavored Frontmatter.

https://github.com/importantimport/fff
https://fff.js.org

Check List

  • Have you read the
    CODE OF CONDUCT
  • Have you read the document
    CONTRIBUTING
    • One pull request per feature. If you want to do more than one thing,
      send multiple pull request.
    • Write tests.
    • Run deno fmt to fix the code format before commit.
    • Document any change in the CHANGELOG.md.

@kwaa
Copy link
Member Author

kwaa commented Dec 20, 2023

@oscarotero Just to ask, is there anything you think needs to be changed?

Also, CI looks broken.

@oscarotero
Copy link
Member

Thanks @kwaa

About the CI, it's caused by this bug on Deno denoland/deno#21601 that is already fixed and hope it will be available in the next release.

I have to check the plugin but it seems to be okay. The only change is regarding to testing: I think it's better to create a test case in the assets folder (assets/fff), create a page with all relevant variables and check if the plugin converts them to fff standard.

@RickCogley
Copy link

The object media feature should be a nice complement to using lume with decapCMS.

@kwaa
Copy link
Member Author

kwaa commented Jan 16, 2024

I'm going to add two more features:

@kwaa kwaa marked this pull request as ready for review January 17, 2024 15:58
@kwaa kwaa requested a review from oscarotero January 17, 2024 16:01
tests/fff.test.ts Show resolved Hide resolved
@oscarotero oscarotero merged commit b97985c into main Jan 22, 2024
3 checks passed
@oscarotero oscarotero deleted the plugins/fff branch January 22, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants