Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onDemand plugin: support async extraData function #561

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

indus
Copy link

@indus indus commented Jan 25, 2024

Description

to support an async extraData function the middleware has to await the response of the function. This also works when a Promise gets returned

Related Issues

Fixes #560

Check List

  • Have you read the
    CODE OF CONDUCT
  • Have you read the document
    CONTRIBUTING
    • One pull request per feature. If you want to do more than one thing,
      send multiple pull request.
    • Write tests.
    • Run deno fmt to fix the code format before commit.
    • Document any change in the CHANGELOG.md.

@oscarotero oscarotero merged commit 1c9c469 into lumeland:main Jan 25, 2024
@oscarotero
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OnDemand: async extraData
2 participants