Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(plugin/favicon): preferred svg icon #562

Merged
merged 7 commits into from
Jan 27, 2024
Merged

refactor(plugin/favicon): preferred svg icon #562

merged 7 commits into from
Jan 27, 2024

Conversation

kwaa
Copy link
Member

@kwaa kwaa commented Jan 27, 2024 •
edited
Loading

Description

This PR makes the favicon plugin follow Definitive edition of "How to Favicon" in 2023 by default.

Related Issues

lumeland/lume.land#99

Check List

  • Have you read the
    CODE OF CONDUCT
  • Have you read the document
    CONTRIBUTING
    • One pull request per feature. If you want to do more than one thing,
      send multiple pull request.
    • Write tests.
    • Run deno fmt to fix the code format before commit.
    • Document any change in the CHANGELOG.md.

@kwaa kwaa changed the title refactor(plugin/favicon): preferred svg icons refactor(plugin/favicon): preferred svg icon Jan 27, 2024
@kwaa kwaa requested a review from oscarotero January 27, 2024 06:25
@oscarotero oscarotero merged commit ae97ef4 into main Jan 27, 2024
3 checks passed
@oscarotero oscarotero deleted the fix/favicon branch January 27, 2024 12:11
@oscarotero
Copy link
Member

Great! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscarotero oscarotero Awaiting requested review from oscarotero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwaa @oscarotero