Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change all usage of dim to gray #566

Merged
merged 4 commits into from
Feb 9, 2024
Merged

fix: change all usage of dim to gray #566

merged 4 commits into from
Feb 9, 2024

Conversation

scarf005
Copy link
Contributor

@scarf005 scarf005 commented Feb 9, 2024 •
edited
Loading

Description

as shown in #563, dim color codes may not work across all browsers. this PR changes all usages of dim into gray for better accessibility across terminals.

Related Issues

none

Check List

  • Have you read the
    CODE OF CONDUCT
  • Have you read the document
    CONTRIBUTING
    • One pull request per feature. If you want to do more than one thing,
      send multiple pull request.
    • Write tests.
    • Run deno fmt to fix the code format before commit.
    • Document any change in the CHANGELOG.md.

@oscarotero oscarotero merged commit 801c84c into lumeland:main Feb 9, 2024
@oscarotero
Copy link
Member

Awesome. Thanks for doing this!

@scarf005 scarf005 deleted the feat/dim-to-gray branch February 9, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scarf005 @oscarotero