Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new server.open option and --open CLI flag #62

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Add new server.open option and --open CLI flag #62

merged 1 commit into from
Apr 14, 2021

Conversation

valtlai
Copy link
Contributor

@valtlai valtlai commented Apr 13, 2021

Works on MacOS, but should be tested on Linux and Windows too.

@oscarotero
Copy link
Member

oscarotero commented Apr 14, 2021

Thanks!
In windows, the command works fine. I couldn't test it in linux but have seen xdg-open <url> in other implementations like this or this. I'm going to ask to a friend with linux to test it, and if it works fine, I'll merge it.

@valtlai
Copy link
Contributor Author

valtlai commented Apr 14, 2021

I switched it to xdg-open because it looks it’s better.

@oscarotero oscarotero merged commit 02b1385 into lumeland:master Apr 14, 2021
@oscarotero
Copy link
Member

Great, thanks!

@valtlai valtlai deleted the cli-open branch April 14, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants