Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Z instead of +00:00 in date("ATOM") filter #64

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Use Z instead of +00:00 in date("ATOM") filter #64

merged 1 commit into from
Apr 15, 2021

Conversation

valtlai
Copy link
Contributor

@valtlai valtlai commented Apr 15, 2021

No description provided.

@oscarotero
Copy link
Member

Is this compatible? I've copied the format from the DATE_ATOM constant in php (https://www.php.net/manual/en/class.datetimeinterface.php#datetime.constants.atom).

@valtlai
Copy link
Contributor Author

valtlai commented Apr 15, 2021

Yes, it is. See the examples on the spec. Also GitHub uses Z in its Atom feeds, such as the one of Lume’s commits.

@oscarotero oscarotero merged commit 3b6b39a into lumeland:master Apr 15, 2021
@oscarotero
Copy link
Member

Ok, got it. Thanks!

@valtlai valtlai deleted the date-z branch April 15, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valtlai @oscarotero