Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds site.preprocess #91

Merged
merged 2 commits into from
May 3, 2021
Merged

Adds site.preprocess #91

merged 2 commits into from
May 3, 2021

Conversation

fserb
Copy link
Contributor

@fserb fserb commented May 2, 2021

This is a first shot at adding site.preprocess().

@oscarotero
Copy link
Member

Thanks!
For performance, I think you should use the same code of the processors:

  • It iterates first the preprocessors, if it's empty we don't need to iterate all pages.
  • It uses the concurrent helper, so all processors are executed in parallel, which is faster.

@fserb
Copy link
Contributor Author

fserb commented May 2, 2021

Ahn, sorry for that. Done.

@oscarotero oscarotero merged commit 1debec2 into lumeland:master May 3, 2021
@oscarotero
Copy link
Member

Thanks! 👍

@fserb fserb deleted the preprocess branch May 3, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants