Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make /archive/* works for lume v2 #17

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Conversation

mmyoji
Copy link
Contributor

@mmyoji mmyoji commented Dec 10, 2023

Thank you for developing and maintaining this module!

I found that /archive/* page doesn't work after updating lume to v2.

ref: https://lume.land/docs/advanced/migrate-to-lume2/#change-.page.*-pages

I tested under ./demo/ directory:

Before

/archive/* was wrongly generated

$ deno task build
Task build deno task lume
Task lume echo "import 'lume/cli.ts'" | deno run --unstable -A -
Loading config file file:///home/mmyoji/dev/tmp/theme-simple-blog/_config.ts
🔥 /404.html /404.md
🔥 /styles.css /styles.css
🔥 /posts/firstpost/ /posts/firstpost.md
🔥 /posts/instructions/ /posts/instructions.md
🔥 /posts/secondpost/ /posts/secondpost.md
🔥 / /index.vto
🔥 /archive.tmpl.js /archive.tmpl.js
🔥 /archive-result.tmpl.js /archive_result.tmpl.js
🔥 /sitemap.xml (generated)
🔥 /robots.txt (generated)
🔥 /pagefind/pagefind.en_fa51ad7f1f.pf_meta (generated)
🔥 /pagefind/wasm.en.pagefind (generated)
🔥 /pagefind/fragment/en_c14eaef.pf_fragment (generated)
🔥 /pagefind/fragment/en_ceaf172.pf_fragment (generated)
🔥 /pagefind/fragment/en_4e57e7a.pf_fragment (generated)
🔥 /pagefind/index/en_7e4ded0.pf_index (generated)
🔥 /pagefind/pagefind.js (generated)
🔥 /pagefind/pagefind-highlight.js (generated)
🔥 /pagefind/pagefind-ui.js (generated)
🔥 /pagefind/pagefind-ui.css (generated)
🔥 /pagefind/pagefind-modular-ui.js (generated)
🔥 /pagefind/pagefind-modular-ui.css (generated)
🔥 /pagefind/wasm.unknown.pagefind (generated)
🔥 /pagefind/pagefind-entry.json (generated)
🔥 /feed.xml (generated)
🔥 /feed.json (generated)
🔥 /favicon.png /favicon.png
🔥 /js/main.js /js/main.js
🔥 /fonts/inter.woff2 /fonts/inter.woff2
🔥 /fonts/epilogue-bold.woff2 /fonts/epilogue-bold.woff2
🔥 /fonts/inter-italic.woff2 /fonts/inter-italic.woff2
🔥 /js/comments.js https://unpkg.com/@oom/mastodon-comments@0.2.1/src/comments.js
🍾 Site built into ./_site
  32 files generated in 7.70 seconds

After

$ deno task build
Task build deno task lume
Task lume echo "import 'lume/cli.ts'" | deno run --unstable -A -
Loading config file file:///home/mmyoji/dev/tmp/theme-simple-blog/_config.ts
🔥 /archive/placeholder/ /archive_result[0].page.js
🔥 /archive/instructions/ /archive_result[5].page.js
🔥 /pagefind/filter/en_91e6758.pf_filter (generated)
🔥 /feed.json (generated)
🔥 /404.html /404.md
🔥 /styles.css /styles.css
🔥 /posts/firstpost/ /posts/firstpost.md
🔥 /posts/instructions/ /posts/instructions.md
🔥 /posts/secondpost/ /posts/secondpost.md
🔥 / /index.vto
🔥 /archive/example/ /archive_result[1].page.js
🔥 /archive/lorem-ipsum/ /archive_result[2].page.js
🔥 /archive/javascript/ /archive_result[3].page.js
🔥 /archive/typescript/ /archive_result[4].page.js
🔥 /author/oscar-otero/ /archive_result[6].page.js
🔥 /archive/ /archive[0].page.js
🔥 /sitemap.xml (generated)
🔥 /robots.txt (generated)
🔥 /pagefind/pagefind.en_847f35bae0.pf_meta (generated)
🔥 /pagefind/wasm.en.pagefind (generated)
🔥 /pagefind/fragment/en_836579e.pf_fragment (generated)
🔥 /pagefind/fragment/en_228db55.pf_fragment (generated)
🔥 /pagefind/fragment/en_45d9bfa.pf_fragment (generated)
🔥 /pagefind/index/en_265dc47.pf_index (generated)
🔥 /pagefind/pagefind.js (generated)
🔥 /pagefind/pagefind-highlight.js (generated)
🔥 /pagefind/pagefind-ui.js (generated)
🔥 /pagefind/pagefind-ui.css (generated)
🔥 /pagefind/pagefind-modular-ui.js (generated)
🔥 /pagefind/pagefind-modular-ui.css (generated)
🔥 /pagefind/wasm.unknown.pagefind (generated)
🔥 /pagefind/pagefind-entry.json (generated)
🔥 /feed.xml (generated)
🔥 /favicon.png /favicon.png
🔥 /js/main.js /js/main.js
🔥 /fonts/inter.woff2 /fonts/inter.woff2
🔥 /fonts/inter-italic.woff2 /fonts/inter-italic.woff2
🔥 /fonts/epilogue-bold.woff2 /fonts/epilogue-bold.woff2
🔥 /js/comments.js https://unpkg.com/@oom/mastodon-comments@0.2.1/src/comments.js
🍾 Site built into ./_site
  39 files generated in 0.19 seconds

@oscarotero oscarotero merged commit be91307 into lumeland:main Dec 10, 2023
@oscarotero
Copy link
Member

Oops. yes, sorry for that.
Thank you!

@mmyoji mmyoji deleted the fix-archive branch December 10, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants