Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize trailing slashes in URLs #30

Open
lunakv opened this issue Feb 7, 2023 · 0 comments
Open

Normalize trailing slashes in URLs #30

lunakv opened this issue Feb 7, 2023 · 0 comments
Labels
infrastructure May need updates outside of application code low priority Things to do when everything else is working

Comments

@lunakv
Copy link
Owner

lunakv commented Feb 7, 2023

Some routes return 307s when sent without a trailing slash. Some return 307 when sent with one. We should make the slash irrelevant and just return the response.

FastAPI doesn't fully support this nicely, so the way to do it is probably with a combination of making sure the line without the trailing slash is always the canonical one (this is not true for router roots), then strip the slash in the nginx proxy.

@lunakv lunakv added infrastructure May need updates outside of application code low priority Things to do when everything else is working labels Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure May need updates outside of application code low priority Things to do when everything else is working
Projects
None yet
Development

No branches or pull requests

1 participant