Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp hand tool also uses the fill tool #78

Closed
duianto opened this issue Jun 11, 2021 · 0 comments
Closed

Temp hand tool also uses the fill tool #78

duianto opened this issue Jun 11, 2021 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@duianto
Copy link

duianto commented Jun 11, 2021

Issue Type: Bug

When panning with the temp hand (space held) tool,
when the fill tool is selected,
and the fill tool has been used at least once.

Then the fill tool is used every time the left mouse button is released after panning.

Reproduction steps

  1. Open an image with different colors,
    or draw two areas with different colors, that can be filled with the fill tool.
  2. Change the foreground color to something that isn't most common on the image.
  3. Select the fill tool.
  4. Fill in one area on the image.
  5. Hold down space.
  6. Hold down the Left mouse button.
  7. Move the mouse button to pan the image.
  8. Release the Left mouse button.

Actual Behavior

The fill tool is used every time the left mouse button
is released while temp panning.

temp_hand_also_uses_main_tool

Expected

The main tool shouldn't be used when temp panning.

Notes

The History window adds new entries of the previous action,
when temp panning after having used the following tools at least once:
Move pixels
Draw rectangle

Extension version: 0.6.0
VS Code version: Code 1.57.0 (b4c1bd0a9b03c749ea011b06c6d2676c8091a70c, 2021-06-09T17:18:42.354Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: Yes

System Info
Item Value
CPUs Intel(R) Core(TM) i3-2100 CPU @ 3.10GHz (4 x 3093)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: unavailable_off
opengl: enabled_on
rasterization: unavailable_off
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 11.96GB (7.17GB free)
Process Argv --crash-reporter-id 59a302e3-5caa-4bda-8390-b451e1103e43
Screen Reader no
VM 0%
A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551cf:30311713
vspre833:30267464
pythonptprofiler:30281270
vshan820:30294714
pythondataviewer:30285071
vscus158cf:30286554
vscgsv2:30307504
vscorehovct:30309550
vscod805:30301674
binariesv517:30312825

@Tyriar Tyriar added the bug Something isn't working label Jun 11, 2021
@Tyriar Tyriar added this to the 0.7.0 milestone Jun 11, 2021
@Tyriar Tyriar closed this as completed Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants