Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hacktoberfest] embed youtube video/videos/playlist to docs where appropriate #234

Closed
ChristianChiarulli opened this issue Oct 3, 2022 · 14 comments · Fixed by #275
Closed
Assignees

Comments

@ChristianChiarulli
Copy link
Member

No description provided.

@jatinmark
Copy link
Contributor

I would like to work on this. Can you please assign this to me?

@jatinmark
Copy link
Contributor

can you please elaborate it .

@jatinmark
Copy link
Contributor

which playlist needs to be embeded.

@thomascft
Copy link

which playlist needs to be embeded.

I assume the objective is to embed videos from the chris@machine for things such as this. The idea is to give new users a video introduction to different nvim concepts. A good place to start may be to embed all of the neovim from scratch videos in their respective locations.

@jatinmark
Copy link
Contributor

jatinmark commented Oct 9, 2022

I added two videos and make a pull request . please check it and give me feedback

@MAHcodes
Copy link
Member

hey @jatinmark,
embedded youtube video has fixed width, so it's causing overflow on small screens < video width,
you can see code example for the fix in src/compontents/YouTube/styles.module.css as a reference.
screenshot showing the issue on Galaxy S7 Edge
photo_2022-10-11_05-55-21 (2)

@jatinmark
Copy link
Contributor

jatinmark commented Oct 12, 2022

@mhmdali102 i am working on this.

@jatinmark
Copy link
Contributor

@mhmdali102 i want to ask that my previous PR is accepted or not , if accepted then i have make an another PR to solve this issue ?

@MAHcodes
Copy link
Member

@jatinmark #243 was merged into master, you need to open another PR to fix this issue.

@MAHcodes
Copy link
Member

@jatinmark fixed it here

@jatinmark
Copy link
Contributor

@mhmdali102 you fixed the issue . Now i am thinking to embed more videos .

@jatinmark
Copy link
Contributor

jatinmark commented Oct 27, 2022

@mhmdali102 & @vonPB can you review it please.

@MAHcodes
Copy link
Member

looks good @jatinmark! I merged ur pr, github closed this issue automatically.

@jatinmark
Copy link
Contributor

@mhmdali102 thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants