Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review request #42

Closed
GoogleCodeExporter opened this issue Jun 12, 2015 · 1 comment
Closed

Code review request #42

GoogleCodeExporter opened this issue Jun 12, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

Purpose of code changes on this branch:
/svn/branches/TRY-JimG-TC4arduino/trunk/artisan.py

Comments received from previous review request have been addressed.  Added some 
sleep time for thread stability.

TRY branch code has been tested on Linux and Windows.  Seems to be working well 
on both systems.

In SampleThread class, switched from using time.clock() to time.time() to 
determine elapsed time (time.clock() was fine on Windows, but did not work as 
expected on Linux systems).

When reviewing my code changes, please focus on:

Changes:
1) Forces samples to occur at even multiples of user-specified delay
2) Improves initialization code for TC4 arduino device
3) Fixes typos that resulted in not calling __init__ for SampleThread

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by pidk...@gmail.com on 25 Jun 2011 at 7:10

@GoogleCodeExporter
Copy link
Author

Closed this out dated issue. The review was done by R.

Original comment by luther.m...@gmail.com on 12 Aug 2011 at 6:57

  • Changed state: Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant