Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong number for AuthMethod.notRequired #3

Closed
simonesestito opened this issue Jan 17, 2024 · 0 comments · Fixed by #4
Closed

Wrong number for AuthMethod.notRequired #3

simonesestito opened this issue Jan 17, 2024 · 0 comments · Fixed by #4

Comments

@simonesestito
Copy link
Contributor

Expected value

According to RFC 1928, the number for "Authentication not required" is 0x00.

      o  X'00' NO AUTHENTICATION REQUIRED
      o  X'01' GSSAPI
      o  X'02' USERNAME/PASSWORD
      o  X'03' to X'7F' IANA ASSIGNED
      o  X'80' to X'FE' RESERVED FOR PRIVATE METHODS
      o  X'FF' NO ACCEPTABLE METHODS

Actual value

From socks.dart:

enum AuthMethod {
  notRequired(0x01),
  // [...]
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix AuthMethod.notRequired according to RFC-1928 simonesestito/dart_socks5_io
1 participant
@simonesestito