Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup working with startupLaunch value #477

Merged
merged 2 commits into from
Mar 31, 2019
Merged

Fixup working with startupLaunch value #477

merged 2 commits into from
Mar 31, 2019

Conversation

greno4ka
Copy link
Contributor

This commit fixes problem, when you want to import or export
information about startup.

So now program can write this value to settings, and then, when it will read it, it first of all analyses if settings value corresponds to file existence, and corrects the situation according to settings' value.

This commit fixes problem, when you want to import or export
information about startup.
@greno4ka
Copy link
Contributor Author

greno4ka commented Mar 7, 2019

So, @lupoDharkael, can you regard this feature?

@greno4ka
Copy link
Contributor Author

I just noticed, that on clean system, .config/autostart can be absent. So the second commit is about verifying the existence of this dir and it's creation, if nessesary. This can be related with many issues about autostart problems.

@greno4ka
Copy link
Contributor Author

Travis has error, not tied with my contribution.

curl: (35) gnutls_handshake() failed: Error in the pull function.
The command "curl --upload-file dist/flameshot_0.6.0_fedora27_x86_64.rpm https://transfer.sh/flameshot_0.6.0_fedora27_x86_64.rpm" failed 3 times.

vt-alt pushed a commit to altlinux/specs that referenced this pull request Mar 12, 2019
- Fixed translation of system buttons in dialogs.
  + (flameshot-org/flameshot#474)
- Added russian translation of desktop file.
  + (flameshot-org/flameshot#475)
- Fixed errors in russian translation.
  + (flameshot-org/flameshot#476)
- Fixed export of startup option in configuration file (Closes: #36149).
  + (flameshot-org/flameshot#477)
- Fixed icon in autostarted program for i586 arch (Closes: #36134).
@lupoDharkael
Copy link
Collaborator

I'm reviewing this tomorrow (sorry for the wait but lately it's hard for me to take time).

@greno4ka
Copy link
Contributor Author

No problem, @lupoDharkael.

@lupoDharkael
Copy link
Collaborator

Seems right to me. Thanks!

@lupoDharkael lupoDharkael merged commit b75ee75 into flameshot-org:master Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants