Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return ZK #380

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Return ZK #380

wants to merge 7 commits into from

Conversation

tyshkor
Copy link

@tyshkor tyshkor commented Apr 23, 2024

No description provided.

Copy link
Member

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyshkor thanks for the PR that goes in an interesting direction. Unfrotunately, I don't manage to get it to compile. Here's a slightly modified branch I used to get past the trivial errors, such as unused imports:
https://github.com/huitseeker/arecibo/tree/return-zk
.. and that seems to not compile.

@tyshkor
Copy link
Author

tyshkor commented May 6, 2024

@tyshkor thanks for the PR that goes in an interesting direction. Unfrotunately, I don't manage to get it to compile. Here's a slightly modified branch I used to get past the trivial errors, such as unused imports: https://github.com/huitseeker/arecibo/tree/return-zk .. and that seems to not compile.

What OS are you using for it?

@huitseeker huitseeker mentioned this pull request May 7, 2024
@huitseeker
Copy link
Member

@tyshkor What OS would you like me to test on? I've done OSX & a linux box, but I don't expect Rust trait implementation failures to be platform-dependent.

Here's a compilation log on Linux:
https://gist.github.com/huitseeker/5208516283766d22ba3df65f7cc3e5ef

A rebase and fixing linting issues would let you get detailed and rapid feedback from our CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants