Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile for fibonacci proof erroring on master branch #116

Closed
jpeg07 opened this issue Jul 12, 2022 · 1 comment · Fixed by #117
Closed

makefile for fibonacci proof erroring on master branch #116

jpeg07 opened this issue Jul 12, 2022 · 1 comment · Fixed by #117
Labels
bug Something isn't working

Comments

@jpeg07
Copy link
Contributor

jpeg07 commented Jul 12, 2022

Currently, running make fibonacci-proof.json on master causes the following error:

➜  examples git:(master) ✗ make fibonacci-proof
cargo run --release -- prove --expression fibonacci.lurk --proof fibonacci-proof.json
    Finished release [optimized] target(s) in 0.09s
     Running `/Users/jonat/lurk-rs/target/release/fcomm prove --expression fibonacci.lurk --proof fibonacci-proof.json`
thread 'main' panicked at 'failed to read file: Error("expected value", line: 1, column: 1)', /Users/jonat/lurk-rs/fcomm/src/lib.rs:413:44
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
make: *** [fibonacci-proof.json] Error 101

README instructions are here.

The above command does work on the fcomm-commitment branch. On master, you have to run the cargo command with --lurk added to make it work (cargo run --release -- prove --expression fibonacci.lurk --proof fibonacci-proof.json --lurk).

It seems like either the JSON needs to be fixed to work as it does on fcomm-commitment branch or the makefile on master needs to update to include --lurk.

@jpeg07 jpeg07 added the bug Something isn't working label Jul 12, 2022
@jpeg07
Copy link
Contributor Author

jpeg07 commented Jul 12, 2022

From @samuelburnham in Discord:

Yeah it seems like the makefile needs to be updated to this [this = cargo run --release -- prove --expression fibonacci.lurk --proof fibonacci-proof.json --lurk]. The CLI expects the expression file to be JSON unless the --lurk flag is passed in. @porcuquine this is the correct behavior right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant