Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Maintenance and update toolchain version #1247

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

huitseeker
Copy link
Member

@huitseeker huitseeker commented May 24, 2024

  • Optimized memory usage by employing efficient cloning through the clone_from method in compute_coeffs and build_frames functions.
  • Included the #[allow(dead_code)] attribute to the CaseClause struct and Op trait, to suppress possible warnings about unused codes.
  • Enhanced constancy in the lurk-metrics/src/lib.rs by making the LOCAL_SINK instantiation constant.
  • Upgraded the Rust toolchain channel from 1.76 to 1.78 in rust-toolchain.toml.
  • Improved clarity and standard compliance by renaming the .cargo/config file to .cargo/config.toml.

FIxes #1232

@huitseeker huitseeker changed the title chore: Optimize code efficiency and update toolchain version chore: Maintenance and update toolchain version May 24, 2024
- Optimized memory usage by employing efficient cloning through the `clone_from` method in `compute_coeffs` and `build_frames` functions.
- Included the `#[allow(dead_code)]` attribute to the `CaseClause` struct and `Op` trait, to suppress possible warnings about unused codes.
- Enhanced constancy in the `lurk-metrics/src/lib.rs` by making the `LOCAL_SINK` instantiation constant.
- Upgraded the Rust toolchain channel from `1.76` to `1.78` in `rust-toolchain.toml`.
- Improved clarity and standard compliance by renaming the .cargo/config file to .cargo/config.toml.
@huitseeker huitseeker marked this pull request as ready for review May 24, 2024 18:11
@huitseeker huitseeker requested review from a team as code owners May 24, 2024 18:11
@huitseeker huitseeker enabled auto-merge May 24, 2024 18:24
@huitseeker huitseeker added this pull request to the merge queue Jun 1, 2024
Merged via the queue into argumentcomputer:main with commit 7febc96 Jun 1, 2024
22 checks passed
@huitseeker huitseeker deleted the maintenance branch June 1, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: rust toolchain needs an upgrade
3 participants