Merging ScalarStore and LightStore into ZStore #351 #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs into jcb/scalar_store_refactor
huitseeker
reviewed
Jul 3, 2023
There was a problem hiding this comment.
I think the main issues left to deal with are:
- the tests in
z-data-{exprs, store}.rswhich are at the moment 100% commented out, - issues to open, notably one for cycle detection in store fetches,
Otherwise, this LGTM! (colossal amount of work, kudos everyone!)
|
|
||
| #[derive(Debug)] | ||
| /// `CacheMap` is an adaptation of `FrozenMap`: | ||
| /// `<https://docs.rs/elsa/latest/elsa/map/struct.FrozenMap.html>` |
There was a problem hiding this comment.
It would also be nice to have a line on what’s different from FrozenMap (the hasher).
| test(&mut s, "0xa/", "0xa"); | ||
| } | ||
| } | ||
| //#[cfg(test)] |
This was referenced Jul 3, 2023
huitseeker
approved these changes
Jul 3, 2023
porcuquine
approved these changes
Jul 4, 2023
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Jul 5, 2023
Since argumentcomputer#364, the store relies on Rc<Refcell<_>> to ensure unique access to the store. This is a runtime check that would lead to a panic should some other piece of code retain a reference to the store in a call to `get_expr`. This PR eliminates the need for this unnecessary construct, and re-established the use of the borrow checker to ensure static memory safety.
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Jul 5, 2023
Since argumentcomputer#364, the store relies on Rc<Refcell<_>> to ensure unique access to the store. This is a runtime check that would lead to a panic should some other piece of code retain a reference to the store in a call to `get_expr`. This PR eliminates the need for this unnecessary construct, and re-established the use of the borrow checker to ensure static memory safety.
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Jul 5, 2023
Since argumentcomputer#364, the store relies on Rc<Refcell<_>> to ensure unique access to the store. This is a runtime check that would lead to a panic should some other piece of code retain a reference to the store in a call to `get_expr`. This PR eliminates the need for this unnecessary construct, and re-established the use of the borrow checker to ensure static memory safety.
This was referenced Jul 6, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
Since #364, the store relies on Rc<Refcell<_>> to ensure unique access to the store. This is a runtime check that would lead to a panic should some other piece of code retain a reference to the store in a call to `get_expr`. This PR eliminates the need for this unnecessary construct, and re-established the use of the borrow checker to ensure static memory safety.
This was referenced Sep 18, 2023
This was referenced Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge LightStore and ScalarStore
(See #352 #353 )