-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add GPU benchmarks and configure with just
script
#790
ci: Add GPU benchmarks and configure with just
script
#790
Conversation
We should switch to fibonacci with a canned config, or more specifically pushing a |
8429381
to
ec70b3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going in the right direction. Hope the comments help!
None of these are disqualifying, but it will need some additional effort if we want the whole team to use it for bench/CI configuration. |
just
configuration for GPU benchmarks and deployment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need a rebase on #808.
For the record, the thing I'm attached to is bench command being separate (in a different file) from github actions / CI workflows. If you would prefer a python script, a shell script, or anything else to host the benchmark command instead of a justfile
@samuelburnham, I will be happy to go with your decision: you own this one.
bd59e54
to
a82780c
Compare
Nothing better immediately comes to mind, pardon the late-night rant 😄 In the interests of time LGTM, and advocate for |
ff960f4
to
a4bba3e
Compare
6d0e4ed
to
511ac76
Compare
f448a79
to
8bff5d5
Compare
* fix: name & checkout * fix just version
8bff5d5
to
5b096ca
Compare
f8c6d7e
to
13592b9
Compare
just
configuration for GPU benchmarks and deploymentjust
script
13592b9
to
bcca690
Compare
bcca690
to
8aa4568
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much, that's a huge step!
Pull Request Benchmarking
This PR enables two methods for testing GPU performance improvement/regression on future pull requests:
issue_comment
: Write!gpu-benchmark
in a PR comment to output a comparativefibonacci_lem
benchmark with the base branch using boa-dev/criterion-compare. This gives an early signal when performance changes seem likely, but isn't required.issue_comment
actions on forked PRs #816fibonacci_lem
performance regressions using a configurable noise threshold (e.g. 5%) and dequeue the PR if a regression is found. This action outputs the PR bench result as a nu11ptr/criterion-table, which is saved as a persistent comment on the commit (find it by clicking on a commit and scrolling to the bottom of the page).Benchmark Reports
When a PR is merged to
master
, a benchmark report for the new commit is deployed to lurk-lab.github.io for historical comparison and user-friendly viewing.Configuration
The GPU benchmarks are run via a
just
script, which allows for benchmark configuration with environment variables in CI. This PR adds support for theLURK_RC
andLURK_BENCH_NOISE_THRESHOLD
variables, which control the reduction counts and noise threshold used in thefibonacci_lem
benchmark.