Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailwind: update readme to note that you must include the css file similar to lustre_ui #30

Closed
xpressivecode opened this issue Apr 28, 2024 · 1 comment

Comments

@xpressivecode
Copy link

It might just be me, but when I first read the readme: "Automatic detection and support for TailwindCSS." I made the assumption that after adding tailwind it would just work. But I had to update the index.html file to include the stylesheet, which makes sense. But it wasn't immediately made clear in the installation directions. When comparing that with the lustre_ui package, it has a small section letting you know to include the css files.

A small quality of life improvement could be scanning the index.html file to see if the stylesheet is missing from head and including it after the write_tailwind_config call. Or alternatively mention it in the output of the cli to include the css file after running the add tailwind command.

@hayleigh-dot-dev
Copy link
Contributor

Or alternatively mention it in the output of the cli to include the css file after running the add tailwind command.

Mentioning it in the CLI output is a great idea. Previously we did used to inject the css directly into the HTML but we switched to generating the HTML once (if it's missing) and letting it be user-editable from there.

Great suggestion, I'll get round to it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants