Winesteam's auto installation crashes

[Letiliel]

Trying to install Shadow Warrior Classic with winesteam runner uninstalled, it crashed when launching the "Where is Steam located?" window, or when closing it.

DEBUG    2014-06-21 20:47:25,008 [jobs]:Async call: install
DEBUG    2014-06-21 20:47:25,009 [wine]:Running wine command: WINEARCH=win32  wine "['msiexec', '/i', '/home/ovo/.cache/lutris/tmp/SteamInstall.msi', '/q']" 
wine: cannot find '['msiexec', '/i', '/home/ovo/.cache/lutris/tmp/SteamInstall.msi', '/q']'
[xcb] Unknown sequence number while processing queue
[xcb] Most likely this is a multi-threaded client and XInitThreads has not been called
[xcb] Aborting, sorry about that.
python2: ../../src/xcb_io.c :274 : poll_for_event:  l'assertion « !xcb_xlib_threads_sequence_lost » a échoué.
Abandon (core dumped)

Installing the runner from the runners config window works OK. (Though Shadow Warrior's install still fails, as stated in #24.)

[Letiliel]

Uh no, this fix was not for this bug...

[Letiliel]

The crash seems due to some threading problem.

[Letiliel]

In fact you have a full suite of functions in installer.py to download and install wine steam and the crash comes from the threading in these various functions.
The whole #Download Steam for Windows block could (should ?) be replaced with a simple call to winesteam.install(). It works and fixes the crash.

[strycore]

You're right, all this wine / winesteam specific code should go into the appropriate runner. This will happen before 0.3.5

[strycore]

Using steam's CDN completely hangs the process but downloading from lutris.net works fine.
btw, you haven't mentioned this in your bug report, which I suspect is the cause for the crash.
wine: cannot find '['msiexec', '/i', '/home/ovo/.cache/lutris/tmp/SteamInstall.msi', '/q']'

This part of lutris is still quite experimental and it still needs much more work but given than I managed to install Quake 2, do you think we can close this and continue working on this for 0.3.6?

[strycore]

Ok, there's something really wrong here, still working on it.

[strycore]

much better now! We are still subject to bug #101 but at least Steam installs fine now