Multi-Select Support for 'Categories' #5376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a category is applied to some but not all selected games, an indeterminate checkbox shows. Click it and it becomes determinate (and checked). On save, any remaining indeterminate categories are skipped, but we work out what categories are to be added or removed for each game in turn. Resolves #5372
This way if you try to use the Categories command while the window is open, it can just adopt additional games. Though without a game list, it's hard to know what the dialog will actually do.
…hown, to avoid the checkbox checking animation. Still can't be an __init__ argument with the games- we need to add games to an already open window.
This is in case you do not realize the dialog is for >1 game; it will warn even if only one is being changed. If you are viewing 1 game and change it, no warning since that is the expected case.
…compare side by side). If you multi-select, we will have a single common multi-category dialog. This can lead to overlap, where a game categories are in two windows. This doesn't seem to cause any real problems. Also, move the game count into a subtitle so it fits better.
…ialog, and also in the sidebar. Also, natural sorting for games in the category-games dialog. Some more commenting too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Categories command to the game-actions when selecting multiple games. This makes it easier to categorize a bunch of games. You can use Lutris's filtering features to find the games, then select games and categorize them in bunches.
Previously you could do the changes one game at a time, or use the edit-category dialog- but with no filtering or anything, just a big stack of check-boxes.
Here's what it looks like when you multi-select and use the 'Categories' command.
Check 'em off an go! But if some games were in categories already, you might see this:
The 'inconsistent' check-boxes can be checked and unchecked, but if left inconsistent then those categories are not updated when you save.
When you do save (with a multi-select) you get a warning dialog:
This is mainly to warn you that this is more than a single game's categories, but the count is accurate- it works out which games require changes, which may not be all you have selected.
Finally, this isn't like 'uninstall games'- you can still get a 'Categories' window for one game at a time, to view side by side say. This means it's possible to get overlapping dialogs, where you are editing the same game in more than one dialog. But that was possible anyway, because you can show the edit dialog for the category itself at the same time.
Resolves #5372