-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add configuration options to change the upstream URL #62
Conversation
I started to work on this issue but I'm getting an error that I can't figure out.
But the code actually takes 2 positional arguments: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I agree with supporting different upstreams, the only thing I would like to explore is having a list of builtin upstreams that users can select, instead of providing text boxes.
Please have a look at my comments and let me know what you think.
@edurenye I have pushed a few commits. Please see the updated description for how it is configured now. Are you able to test this locally? Preliminary tests are working for me but since the clamps on my Wibeee are measuring devices that are not often the device ends up sending data only every 1 minute anyway. |
Nice, I'll try it out, thank you! |
Well, I'll wait to test the pushing since some times it malfunctions when changing the configuration and I need to reset the wibeee, wanna be there phisically to be able to reset, I contacted SolarProfit regarding this issue and they said a technician would contact me but it's been a while and the haven't contacted me, so I'll have to call them again. |
Allows selecting a different Cloud service to upload. Also introduces Local-only mode for those who want to use Local Push without sending the data off to any Cloud service.
When running the new version for the first time the
ConfigEntry
is migrated to version 2 to support the new configuration select box.