RFR: Refactor #84
Merged
RFR: Refactor #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@creationix oh i see, sorry for the confusion |
| local match, hash = db.match(author, pname, version) | ||
|
|
||
| if not match then | ||
| error("No such " |
There was a problem hiding this comment.
There isn't much static content, it would look like:
error(string.format("No such %s: %s%s",
version and "version" or "package",
name,
version and '@' .. version or ''))I'll change it if you prefer string.format here.
There was a problem hiding this comment.
ah... yeah, that isn't much change. nm
|
minor nit, we should probably add the luvit/luvi license to the source files as well. |
Closed
|
+1... i do think the license headers would be good to add as well |
creationix
force-pushed
the
refactor
branch
2 times, most recently
from
f77df9b
to
121759f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the internals a lot to be more modular and saner logic.