Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Lua version check #504

Merged
merged 1 commit into from
Jul 12, 2020
Merged

Update Lua version check #504

merged 1 commit into from
Jul 12, 2020

Conversation

javalikescript
Copy link
Contributor

Building using the new Lua 5.4 version fails due to the included file compat-5.3.h

@SinisterRectus
Copy link
Member

Looks okay to me, but I think we need to make a formal effort to support 5.4. See #497.

@javalikescript
Copy link
Contributor Author

I would love luv to fully support Lua 5.4! The goal of this pull request is only to allow compilation.
I use a subset of luv with the latest Lua version and I have my own tests. This change allow me to continue to reference the luvit/luv repository waiting for a more broader support.

@zhaozg
Copy link
Member

zhaozg commented Jul 12, 2020

And should update submodule lua compat 5.3

@squeek502 squeek502 merged commit 741db3d into luvit:master Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaozg zhaozg zhaozg approved these changes

@squeek502 squeek502 squeek502 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@javalikescript @SinisterRectus @zhaozg @squeek502