WIP: Schema #82
Closed
WIP: Schema #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen if the first malloc for `buf.base` succeeds, but then the second malloc for req->data fails.
| int64_t len = luaL_checkinteger(L, 2); | ||
| int64_t offset = luaL_checkinteger(L, 3); | ||
| uv_file file; | ||
| int64_t len, offset; |
There was a problem hiding this comment.
Just trying to match what libuv is expecting to go through minimal typecasts.
offset declared at https://github.com/joyent/libuv/blob/a4f88760be1838603fe2eae89a651066cc42eedd/include/uv.h#L1072
though I got size wrong, it should be unsigned int from https://github.com/joyent/libuv/blob/a4f88760be1838603fe2eae89a651066cc42eedd/include/uv.h#L416
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to go through all the user-facing functions and organize them into 3 sections.
1 - Declare all local variables at the top
2 - Check the arguments against a static schema
3 - Perform the action being aware of early exits and cleanup of resources.
There are quite a few memory leaks that are only triggered by various error cases. This refactor should fix most if not all of them.