Merge in Master branch changes, add len() functionality to the LuxSQLTable #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"name" parameter was being added again unnecessarily in lux series and tests for series
Issue when running test_vis in Github Actions. Adjusted test_scatter_chart and test_colored_scatter_chart
* coalesce data_types into data_type_lookup * merge fixed * merge conflicts * first commit * requirements.txt updated for pandas 1.2.2 * revert cardinality requiremment * black reformat * all tests passing with cardinality optimization * remove abs value * tests added * black reformat * minor fixes * black Co-authored-by: Doris Lee <dorisjunglinlee@gmail.com>
Lux config now shoots an error if a user specifies a non-existent executor type
Removed unnecessary hyperparameter transferring in the Vis object. Update LuxSQLTable to display have more verbose display notification.
* fix repr to display string of df * replace repr_html to move widget into Out * replace repr_html in other files * fix issue for LuxSeries
Update test_interestingness to test for deviation_from_overall changes when using the SQLExecutor
The _length parameter keeps track of the number of datapoints within the table/view that a LuxSQLTable is connected to. Added a len() function to make this parameter accessible. Unable to override the __len__() function as doing so breaks an assertion within the parent DataFrame class Updated interestingness.py to use the new len() function
Adding back in the _length parameter to the LuxDataFrame
Rather than referencing the _length parameter throughout the code, update and use the LuxSQLTable len() function. Added _setup_done parameter to the LuxSQLTable. This will check if the initial setup of the table, retrieving and populating attributes, is completed. This will inform which len() function to use, as the parent len() is required while populating the columns of the LuxSQLTable.
Rename _repr_html_() to _ipython_display_()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Merging in recent master branch changes. handling.