Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set lens position from calibration data #496

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

SzabolcsGergely
Copy link
Collaborator

@SzabolcsGergely SzabolcsGergely commented Jun 3, 2022

Initally we used value 130 for lens position during calibration, which got hard-coded in examples. but that is now changed, camera dependent.

Reading the value from calibration data prior to setting lens position ensures correct RGB alignment for all boards.

Copy link
Collaborator

@themarpe themarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we rather make this auto behavior and apply it from FW if not explicitly set otherwise?
CC: @Erol444

@SzabolcsGergely SzabolcsGergely merged commit a4a385a into develop Jun 8, 2022
@SzabolcsGergely SzabolcsGergely deleted the lens_position_from_calib branch June 8, 2022 14:11
@SzabolcsGergely
Copy link
Collaborator Author

Shall we rather make this auto behavior and apply it from FW if not explicitly set otherwise? CC: @Erol444

Up to debate, merged for now, since it's an upgrade till we decide if we should or not.

@SzabolcsGergely SzabolcsGergely mentioned this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants