Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calibration rvc3 #1060

Merged
merged 66 commits into from
Jul 18, 2023
Merged

Calibration rvc3 #1060

merged 66 commits into from
Jul 18, 2023

Conversation

MaticTonin
Copy link
Contributor

Update on calibrate.py file.

saching13 and others added 30 commits August 9, 2022 10:17
@saching13
Added WIP Image Align for visualization
186abae
@saching13
Working calibration with SYnc
5113b6b
@saching13
added board config files
fcc4f4c
@saching13
Updated the ar0234 res
e52e734
@saching13
Updated mono in json
562d331
@saching13
Added Output Scale factor and removed the orientation check
d9105b1
@saching13
Fixed the osf
48cdb67
@saching13
Fixed capture issue with different names
f177b01
@saching13
updated links translation
507ede9
@saching13
WIP structure and vertical Stereo calibration
46f8b1f
@saching13
Fixed flashing issues
03766f3
@saching13
updatec req condfitions
84dd899
@saching13
added exception msg
16f6e28
@saching13
removed try catch and writing board names
7b81117
@saching13
adding rect data
1b356df
@saching13
Updated rectification flash
64d5828
@saching13
Removed comments
c9bc18e
@saching13
Added rotation to polygons
38e6102
@saching13
Polygon flex (#789)
861f9e3 
* Optimization and trace levels introduced WIP

* tweaked parameters and updated tracelevel
@saching13
Modified the board file
00acebb
@saching13
added debugs
63b5adb
@saching13
tweaked intrinsics in use
7372329
@saching13
iterative method added but commented
085b4a6
@saching13
cleanedup image sizes and better ep errors
6d3964a
@saching13
Fixed config error
1067cb2
@saching13
Tweaked replay
c452188
@saching13
Added optional rect from projection matrix
029aff0
@saching13
updated depthai version
6f186a6
@alex-luxonis
Add -ab/--antibanding {50|60|off} option. Implement -fps option
9deb126
@njezersek
Peripheral calibration - fisheye camera model (#952)
691f680 
* Make sure the same points are present on all images

* Use initUndistortRectifyMap from fisheye calib
saching13 and others added 9 commits May 17, 2023 14:52
@saching13
Cleared old opencv dependencies versioning
bc9f90d
@saching13
Peripheral calibration rvc3 (#1040)
53445f2 
* if fisheye changed the requiement to need all the corners on the board

* added coverage window

* added charuco cornes and coverage visualization

* small improvements

* added marker visualization for capture

* removed merge datasets

* reprojection error and cover image

* removed unused name
@saching13
fixed the requirements.txt
e4e7bea
@saching13
saving converge files
8601c51
@saching13
modified calibration parameters
d5da79f
@saching13
added json for no vertical testing
469d6df
@MaticTonin
Changes
d7af1ad
@MaticTonin
Adding_display_option
4c04197
@MaticTonin
Adding_display_option
3bc52a9
saching13
saching13 suggested changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@saching13 saching13 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some fixes.

  • depthai_helpers/calibration_utils_old.py remove this file
  • remove the local board files and make sure the code to use depthai_boards submodule

calibrate.py Outdated Show resolved Hide resolved
calibrate.py Outdated Show resolved Hide resolved
calibrate.py Outdated Show resolved Hide resolved
depthai_helpers/calibration_utils.py Outdated Show resolved Hide resolved
depthai_helpers/calibration_utils.py Outdated Show resolved Hide resolved
depthai_helpers/calibration_utils.py Outdated Show resolved Hide resolved
depthai_helpers/calibration_utils.py Outdated Show resolved Hide resolved
saching13
saching13 approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@saching13 saching13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please test calibration on OAK-D, OAK-D-W. and a PoE device before merging and check the visual depth quality before merging.

saching13
saching13 suggested changes Jul 11, 2023
View reviewed changes
calibrate.py Outdated Show resolved Hide resolved
calibrate.py Outdated Show resolved Hide resolved
calibrate.py Outdated Show resolved Hide resolved
calibrate.py Outdated Show resolved Hide resolved
calibrate.py Outdated Show resolved Hide resolved
calibrate.py Outdated Show resolved Hide resolved
depthai_helpers/calibration_utils.py Outdated Show resolved Hide resolved
depthai_helpers/calibration_utils.py Outdated Show resolved Hide resolved
depthai_helpers/calibration_utils.py Outdated Show resolved Hide resolved
depthai_helpers/calibration_utils.py Outdated Show resolved Hide resolved
saching13
saching13 reviewed Jul 14, 2023
View reviewed changes
Copy link
Contributor

@saching13 saching13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added additional comments

DepthCapture_2023-06-27-14-50-40.png Outdated Show resolved Hide resolved
calibrate.py Outdated Show resolved Hide resolved
DepthCamera_2023-06-27-14-50-40.json Outdated Show resolved Hide resolved
resources/boards/veermer_no_rgb.json Outdated Show resolved Hide resolved
saching13
saching13 suggested changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@saching13 saching13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the trace level operation and don't introduce display_all.

depthai_helpers/calibration_utils.py Outdated Show resolved Hide resolved
depthai_helpers/calibration_utils.py Outdated Show resolved Hide resolved
saching13
saching13 approved these changes Jul 18, 2023
View reviewed changes
calibrate.py Outdated Show resolved Hide resolved
@saching13 saching13 merged commit 601f3df into main Jul 18, 2023
23 of 29 checks passed
@saching13 saching13 deleted the calibration_rvc3 branch July 18, 2023 17:26
@geektrove geektrove mentioned this pull request Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saching13 saching13 saching13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MaticTonin @saching13 @alex-luxonis @njezersek