Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peripheral calibration - fisheye camera model #952

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

njezersek
Copy link
Contributor

Trying to get the fisheye camera model working

Copy link
Contributor

@saching13 saching13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saching13 saching13 merged commit 691f680 into peripheral_calibration Feb 22, 2023
@saching13 saching13 deleted the peripheral_calibration_fisheye branch February 22, 2023 16:40
saching13 added a commit that referenced this pull request May 20, 2023
* Added WIP Image Align for visualization

* Working calibration with SYnc

* added board config files

* Updated the ar0234 res

* Updated mono in json

* Added Output Scale factor and removed the orientation check

* Fixed the osf

* Fixed capture issue with different names

* updated links translation

* WIP structure and vertical Stereo calibration

* Fixed flashing issues

* updatec req condfitions

* added exception msg

* removed try catch and writing board names

* adding rect data

* Updated rectification flash

* Removed comments

* Added rotation to polygons

* Polygon flex (#789)

* Optimization and trace levels introduced WIP

* tweaked parameters and updated tracelevel

* Modified the board file

* added debugs

* tweaked intrinsics in use

* iterative method added but commented

* cleanedup image sizes and better ep errors

* Fixed config error

* Tweaked replay

* Added optional rect from projection matrix

* updated depthai version

* Add `-ab/--antibanding {50|60|off}` option. Implement `-fps` option

* Peripheral calibration - fisheye camera model (#952)

* Make sure the same points are present on all images

* Use initUndistortRectifyMap from fisheye calib

* Fix fiheye calibration rotated rectified image

* new lines from corner to corners

* update calibration handler with cameraModel

* WIP vermeer

* Fix fisheye calibration

* Fixes for RVC3

* Add mouse trigger, save calibration, custom dataset options

* Update depthai version

* Add options for dataset custom path

* Add an option to manually specify the number of charucos

* Fixed default dataset path

* Support for GRAY8 img type, fix scaling issues

* Cleanup

* Added image_scaler

* Added support for reading the camera model from json file

* Added traceLevel command line flag

* removed commented code

---------

Co-authored-by: Sachin <sachin.guruswamy@gmail.com>
Co-authored-by: Sachin Guruswamy <43363595+saching13@users.noreply.github.com>
Co-authored-by: alex-luxonis <alex@luxonis.com>
Co-authored-by: Matevz Morato <matevz.morato@gmail.com>
alex-luxonis added a commit that referenced this pull request May 24, 2023
* Added WIP Image Align for visualization

* Working calibration with SYnc

* added board config files

* Updated the ar0234 res

* Updated mono in json

* Added Output Scale factor and removed the orientation check

* Fixed the osf

* Fixed capture issue with different names

* updated links translation

* WIP structure and vertical Stereo calibration

* Fixed flashing issues

* updatec req condfitions

* added exception msg

* removed try catch and writing board names

* adding rect data

* Updated rectification flash

* Removed comments

* Added rotation to polygons

* Polygon flex (#789)

* Optimization and trace levels introduced WIP

* tweaked parameters and updated tracelevel

* Modified the board file

* added debugs

* tweaked intrinsics in use

* iterative method added but commented

* cleanedup image sizes and better ep errors

* Fixed config error

* Tweaked replay

* Added optional rect from projection matrix

* updated depthai version

* Add `-ab/--antibanding {50|60|off}` option. Implement `-fps` option

* Peripheral calibration - fisheye camera model (#952)

* Make sure the same points are present on all images

* Use initUndistortRectifyMap from fisheye calib

* Fix fiheye calibration rotated rectified image

* new lines from corner to corners

* update calibration handler with cameraModel

* Fix fisheye calibration

* Fixes for RVC3

* Add mouse trigger, save calibration, custom dataset options

* Update depthai version

* Add options for dataset custom path

* Add an option to manually specify the number of charucos

* Fixed default dataset path

* Support for GRAY8 img type, fix scaling issues

* Cleanup

* Added image_scaler

* Added support for reading the camera model from json file

* Added traceLevel command line flag

* removed commented code

---------

Co-authored-by: Sachin <sachin.guruswamy@gmail.com>
Co-authored-by: Sachin Guruswamy <43363595+saching13@users.noreply.github.com>
Co-authored-by: alex-luxonis <alex@luxonis.com>
Co-authored-by: Matevz Morato <matevz.morato@gmail.com>
daniilpastukhov pushed a commit that referenced this pull request Jun 5, 2023
* Added WIP Image Align for visualization

* Working calibration with SYnc

* added board config files

* Updated the ar0234 res

* Updated mono in json

* Added Output Scale factor and removed the orientation check

* Fixed the osf

* Fixed capture issue with different names

* updated links translation

* WIP structure and vertical Stereo calibration

* Fixed flashing issues

* updatec req condfitions

* added exception msg

* removed try catch and writing board names

* adding rect data

* Updated rectification flash

* Removed comments

* Added rotation to polygons

* Polygon flex (#789)

* Optimization and trace levels introduced WIP

* tweaked parameters and updated tracelevel

* Modified the board file

* added debugs

* tweaked intrinsics in use

* iterative method added but commented

* cleanedup image sizes and better ep errors

* Fixed config error

* Tweaked replay

* Added optional rect from projection matrix

* updated depthai version

* Add `-ab/--antibanding {50|60|off}` option. Implement `-fps` option

* Peripheral calibration - fisheye camera model (#952)

* Make sure the same points are present on all images

* Use initUndistortRectifyMap from fisheye calib

* Fix fiheye calibration rotated rectified image

* new lines from corner to corners

* update calibration handler with cameraModel

* WIP vermeer

* Fix fisheye calibration

* Fixes for RVC3

* Add mouse trigger, save calibration, custom dataset options

* Update depthai version

* Add options for dataset custom path

* Add an option to manually specify the number of charucos

* Fixed default dataset path

* Support for GRAY8 img type, fix scaling issues

* Cleanup

* Added image_scaler

* Added support for reading the camera model from json file

* Added traceLevel command line flag

* removed commented code

---------

Co-authored-by: Sachin <sachin.guruswamy@gmail.com>
Co-authored-by: Sachin Guruswamy <43363595+saching13@users.noreply.github.com>
Co-authored-by: alex-luxonis <alex@luxonis.com>
Co-authored-by: Matevz Morato <matevz.morato@gmail.com>
saching13 added a commit that referenced this pull request Jul 18, 2023
* Added WIP Image Align for visualization

* Working calibration with SYnc

* added board config files

* Updated the ar0234 res

* Updated mono in json

* Added Output Scale factor and removed the orientation check

* Fixed the osf

* Fixed capture issue with different names

* updated links translation

* WIP structure and vertical Stereo calibration

* Fixed flashing issues

* updatec req condfitions

* added exception msg

* removed try catch and writing board names

* adding rect data

* Updated rectification flash

* Removed comments

* Added rotation to polygons

* Polygon flex (#789)

* Optimization and trace levels introduced WIP

* tweaked parameters and updated tracelevel

* Modified the board file

* added debugs

* tweaked intrinsics in use

* iterative method added but commented

* cleanedup image sizes and better ep errors

* Fixed config error

* Tweaked replay

* Added optional rect from projection matrix

* updated depthai version

* Add `-ab/--antibanding {50|60|off}` option. Implement `-fps` option

* Peripheral calibration - fisheye camera model (#952)

* Make sure the same points are present on all images

* Use initUndistortRectifyMap from fisheye calib

* Fix fiheye calibration rotated rectified image

* new lines from corner to corners

* update calibration handler with cameraModel

* WIP vermeer

* Fix fisheye calibration

* Fixes for RVC3

* Add mouse trigger, save calibration, custom dataset options

* Update depthai version

* Add options for dataset custom path

* Add an option to manually specify the number of charucos

* Fixed default dataset path

* Support for GRAY8 img type, fix scaling issues

* Lower the threshold for synced frames

* Remove the CALIB_CHECK_COND

* Cleared old opencv dependencies versioning

* Peripheral calibration rvc3 (#1040)

* if fisheye changed the requiement to need all the corners on the board

* added coverage window

* added charuco cornes and coverage visualization

* small improvements

* added marker visualization for capture

* removed merge datasets

* reprojection error and cover image

* removed unused name

* fixed the requirements.txt

* saving converge files

* modified calibration parameters

* added json for no vertical testing

* Changes

* Adding_display_option

* Adding_display_option

* Changes

* Change

* Resolving_issues

* Resolving_issues

* Fix issues

* Change in scaling matrix

* Changes of matrix

* Adding traceLevel as argument

* Fix traceLevel

* updated the argument.

---------

Co-authored-by: Sachin <sachin.guruswamy@gmail.com>
Co-authored-by: Sachin Guruswamy <43363595+saching13@users.noreply.github.com>
Co-authored-by: alex-luxonis <alex@luxonis.com>
Co-authored-by: Nejc Jezeršek <njezersek@gmail.com>
Co-authored-by: Matevz Morato <matevz.morato@gmail.com>
saching13 added a commit that referenced this pull request Aug 11, 2023
* Added WIP Image Align for visualization

* Working calibration with SYnc

* added board config files

* Updated the ar0234 res

* Updated mono in json

* Added Output Scale factor and removed the orientation check

* Fixed the osf

* Fixed capture issue with different names

* updated links translation

* WIP structure and vertical Stereo calibration

* Fixed flashing issues

* updatec req condfitions

* added exception msg

* removed try catch and writing board names

* adding rect data

* Updated rectification flash

* Removed comments

* Added rotation to polygons

* Polygon flex (#789)

* Optimization and trace levels introduced WIP

* tweaked parameters and updated tracelevel

* Modified the board file

* added debugs

* tweaked intrinsics in use

* iterative method added but commented

* cleanedup image sizes and better ep errors

* Fixed config error

* Tweaked replay

* Added optional rect from projection matrix

* updated depthai version

* Add `-ab/--antibanding {50|60|off}` option. Implement `-fps` option

* Peripheral calibration - fisheye camera model (#952)

* Make sure the same points are present on all images

* Use initUndistortRectifyMap from fisheye calib

* Fix fiheye calibration rotated rectified image

* new lines from corner to corners

* update calibration handler with cameraModel

* WIP vermeer

* Fix fisheye calibration

* Fixes for RVC3

* Add mouse trigger, save calibration, custom dataset options

* Update depthai version

* Add options for dataset custom path

* Add an option to manually specify the number of charucos

* Fixed default dataset path

* Support for GRAY8 img type, fix scaling issues

* Lower the threshold for synced frames

* Remove the CALIB_CHECK_COND

* Cleared old opencv dependencies versioning

* Peripheral calibration rvc3 (#1040)

* if fisheye changed the requiement to need all the corners on the board

* added coverage window

* added charuco cornes and coverage visualization

* small improvements

* added marker visualization for capture

* removed merge datasets

* reprojection error and cover image

* removed unused name

* fixed the requirements.txt

* saving converge files

* modified calibration parameters

* added json for no vertical testing

* Changes

* Adding_display_option

* Adding_display_option

* Changes

* Adding changes in parameteres

* Testing on OAK-D-PRO and small changes

* Change in rescale of text in combined images

* Adding the combinedCoverageimages

* Update on calibrate.py

* Adding the submodules and calibration file

* Path to depthai_calibtraion

* Path to submodule

* Adding output scale factor as arg

* Fixing traceLvl and timesync

* Changed traceLevel as argument

---------

Co-authored-by: Sachin <sachin.guruswamy@gmail.com>
Co-authored-by: Sachin Guruswamy <43363595+saching13@users.noreply.github.com>
Co-authored-by: alex-luxonis <alex@luxonis.com>
Co-authored-by: Nejc Jezeršek <njezersek@gmail.com>
Co-authored-by: Matevz Morato <matevz.morato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants