-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polygon flex #789
Merged
Merged
Polygon flex #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njezersek
added a commit
that referenced
this pull request
Apr 3, 2023
* Added WIP Image Align for visualization * Working calibration with SYnc * added board config files * Updated the ar0234 res * Updated mono in json * Added Output Scale factor and removed the orientation check * Fixed the osf * Fixed capture issue with different names * updated links translation * WIP structure and vertical Stereo calibration * Fixed flashing issues * updatec req condfitions * added exception msg * removed try catch and writing board names * adding rect data * Updated rectification flash * Removed comments * Added rotation to polygons * Polygon flex (#789) * Optimization and trace levels introduced WIP * tweaked parameters and updated tracelevel * Modified the board file * added debugs * tweaked intrinsics in use * iterative method added but commented * cleanedup image sizes and better ep errors * adapt calib script to main depthai * Fixed config error * changed to features in calibration * adjust horizontal values * Tuning calibration testing epipolar error * oak-d-sr calibration * Added error for file * add hasAutoFocus check back * changed to fix Intrinsics * cleared old file * Added OAK-D-LR support * add oak-d-cm4-c11 calibration file * Add support for IMX296 camera * Check if markers were detected on undistorted image (#927) * Added a check to detect if there were no markers found on the undistored image * Added an error if no markers are found in more than 2 images * Fix default lens position for OAK-D-LITE * Use board files from depthai-boards submodule * Download submodules automatically if they're missing * Modular calibration lr (#984) * Further OAK-D-LR modifications * Added fixed exposure and wb * Further LR improvements, mainly synchronization related * Fixed some issues and tweaked streaming for LR a bit * Modified default queue depth to 4 * Added missing scipy dependency * Fixed HFOV for OAK-D-LR * Fix misplaced parameters for MessageSync * Exposed 'flashing' stage/mode to be separate from 'process' * Varius bug fixes * Fix missing dest_path, fix AR0234 mono resolution * Set ISP scale for AR0234 --------- Co-authored-by: Martin Peterlin <martin.peterlin7@gmail.com> Co-authored-by: Matevz Morato <matevz.morato@gmail.com> Co-authored-by: TheMarpe <martin@luxonis.com> --------- Co-authored-by: Sachin <sachin.guruswamy@gmail.com> Co-authored-by: Sachin Guruswamy <43363595+saching13@users.noreply.github.com> Co-authored-by: Daniel Calaver <calaver@luxonis.com> Co-authored-by: TheMarpe <martin.peterlin7@gmail.com> Co-authored-by: Erol444 <erol123444@gmail.com> Co-authored-by: Matevz Morato <matevz.morato@gmail.com> Co-authored-by: TheMarpe <martin@luxonis.com>
saching13
added a commit
that referenced
this pull request
May 20, 2023
* Added WIP Image Align for visualization * Working calibration with SYnc * added board config files * Updated the ar0234 res * Updated mono in json * Added Output Scale factor and removed the orientation check * Fixed the osf * Fixed capture issue with different names * updated links translation * WIP structure and vertical Stereo calibration * Fixed flashing issues * updatec req condfitions * added exception msg * removed try catch and writing board names * adding rect data * Updated rectification flash * Removed comments * Added rotation to polygons * Polygon flex (#789) * Optimization and trace levels introduced WIP * tweaked parameters and updated tracelevel * Modified the board file * added debugs * tweaked intrinsics in use * iterative method added but commented * cleanedup image sizes and better ep errors * Fixed config error * Tweaked replay * Added optional rect from projection matrix * updated depthai version * Add `-ab/--antibanding {50|60|off}` option. Implement `-fps` option * Peripheral calibration - fisheye camera model (#952) * Make sure the same points are present on all images * Use initUndistortRectifyMap from fisheye calib * Fix fiheye calibration rotated rectified image * new lines from corner to corners * update calibration handler with cameraModel * WIP vermeer * Fix fisheye calibration * Fixes for RVC3 * Add mouse trigger, save calibration, custom dataset options * Update depthai version * Add options for dataset custom path * Add an option to manually specify the number of charucos * Fixed default dataset path * Support for GRAY8 img type, fix scaling issues * Cleanup * Added image_scaler * Added support for reading the camera model from json file * Added traceLevel command line flag * removed commented code --------- Co-authored-by: Sachin <sachin.guruswamy@gmail.com> Co-authored-by: Sachin Guruswamy <43363595+saching13@users.noreply.github.com> Co-authored-by: alex-luxonis <alex@luxonis.com> Co-authored-by: Matevz Morato <matevz.morato@gmail.com>
alex-luxonis
added a commit
that referenced
this pull request
May 24, 2023
* Added WIP Image Align for visualization * Working calibration with SYnc * added board config files * Updated the ar0234 res * Updated mono in json * Added Output Scale factor and removed the orientation check * Fixed the osf * Fixed capture issue with different names * updated links translation * WIP structure and vertical Stereo calibration * Fixed flashing issues * updatec req condfitions * added exception msg * removed try catch and writing board names * adding rect data * Updated rectification flash * Removed comments * Added rotation to polygons * Polygon flex (#789) * Optimization and trace levels introduced WIP * tweaked parameters and updated tracelevel * Modified the board file * added debugs * tweaked intrinsics in use * iterative method added but commented * cleanedup image sizes and better ep errors * Fixed config error * Tweaked replay * Added optional rect from projection matrix * updated depthai version * Add `-ab/--antibanding {50|60|off}` option. Implement `-fps` option * Peripheral calibration - fisheye camera model (#952) * Make sure the same points are present on all images * Use initUndistortRectifyMap from fisheye calib * Fix fiheye calibration rotated rectified image * new lines from corner to corners * update calibration handler with cameraModel * Fix fisheye calibration * Fixes for RVC3 * Add mouse trigger, save calibration, custom dataset options * Update depthai version * Add options for dataset custom path * Add an option to manually specify the number of charucos * Fixed default dataset path * Support for GRAY8 img type, fix scaling issues * Cleanup * Added image_scaler * Added support for reading the camera model from json file * Added traceLevel command line flag * removed commented code --------- Co-authored-by: Sachin <sachin.guruswamy@gmail.com> Co-authored-by: Sachin Guruswamy <43363595+saching13@users.noreply.github.com> Co-authored-by: alex-luxonis <alex@luxonis.com> Co-authored-by: Matevz Morato <matevz.morato@gmail.com>
daniilpastukhov
pushed a commit
that referenced
this pull request
Jun 5, 2023
* Added WIP Image Align for visualization * Working calibration with SYnc * added board config files * Updated the ar0234 res * Updated mono in json * Added Output Scale factor and removed the orientation check * Fixed the osf * Fixed capture issue with different names * updated links translation * WIP structure and vertical Stereo calibration * Fixed flashing issues * updatec req condfitions * added exception msg * removed try catch and writing board names * adding rect data * Updated rectification flash * Removed comments * Added rotation to polygons * Polygon flex (#789) * Optimization and trace levels introduced WIP * tweaked parameters and updated tracelevel * Modified the board file * added debugs * tweaked intrinsics in use * iterative method added but commented * cleanedup image sizes and better ep errors * Fixed config error * Tweaked replay * Added optional rect from projection matrix * updated depthai version * Add `-ab/--antibanding {50|60|off}` option. Implement `-fps` option * Peripheral calibration - fisheye camera model (#952) * Make sure the same points are present on all images * Use initUndistortRectifyMap from fisheye calib * Fix fiheye calibration rotated rectified image * new lines from corner to corners * update calibration handler with cameraModel * WIP vermeer * Fix fisheye calibration * Fixes for RVC3 * Add mouse trigger, save calibration, custom dataset options * Update depthai version * Add options for dataset custom path * Add an option to manually specify the number of charucos * Fixed default dataset path * Support for GRAY8 img type, fix scaling issues * Cleanup * Added image_scaler * Added support for reading the camera model from json file * Added traceLevel command line flag * removed commented code --------- Co-authored-by: Sachin <sachin.guruswamy@gmail.com> Co-authored-by: Sachin Guruswamy <43363595+saching13@users.noreply.github.com> Co-authored-by: alex-luxonis <alex@luxonis.com> Co-authored-by: Matevz Morato <matevz.morato@gmail.com>
saching13
added a commit
that referenced
this pull request
Jul 18, 2023
* Added WIP Image Align for visualization * Working calibration with SYnc * added board config files * Updated the ar0234 res * Updated mono in json * Added Output Scale factor and removed the orientation check * Fixed the osf * Fixed capture issue with different names * updated links translation * WIP structure and vertical Stereo calibration * Fixed flashing issues * updatec req condfitions * added exception msg * removed try catch and writing board names * adding rect data * Updated rectification flash * Removed comments * Added rotation to polygons * Polygon flex (#789) * Optimization and trace levels introduced WIP * tweaked parameters and updated tracelevel * Modified the board file * added debugs * tweaked intrinsics in use * iterative method added but commented * cleanedup image sizes and better ep errors * Fixed config error * Tweaked replay * Added optional rect from projection matrix * updated depthai version * Add `-ab/--antibanding {50|60|off}` option. Implement `-fps` option * Peripheral calibration - fisheye camera model (#952) * Make sure the same points are present on all images * Use initUndistortRectifyMap from fisheye calib * Fix fiheye calibration rotated rectified image * new lines from corner to corners * update calibration handler with cameraModel * WIP vermeer * Fix fisheye calibration * Fixes for RVC3 * Add mouse trigger, save calibration, custom dataset options * Update depthai version * Add options for dataset custom path * Add an option to manually specify the number of charucos * Fixed default dataset path * Support for GRAY8 img type, fix scaling issues * Lower the threshold for synced frames * Remove the CALIB_CHECK_COND * Cleared old opencv dependencies versioning * Peripheral calibration rvc3 (#1040) * if fisheye changed the requiement to need all the corners on the board * added coverage window * added charuco cornes and coverage visualization * small improvements * added marker visualization for capture * removed merge datasets * reprojection error and cover image * removed unused name * fixed the requirements.txt * saving converge files * modified calibration parameters * added json for no vertical testing * Changes * Adding_display_option * Adding_display_option * Changes * Change * Resolving_issues * Resolving_issues * Fix issues * Change in scaling matrix * Changes of matrix * Adding traceLevel as argument * Fix traceLevel * updated the argument. --------- Co-authored-by: Sachin <sachin.guruswamy@gmail.com> Co-authored-by: Sachin Guruswamy <43363595+saching13@users.noreply.github.com> Co-authored-by: alex-luxonis <alex@luxonis.com> Co-authored-by: Nejc Jezeršek <njezersek@gmail.com> Co-authored-by: Matevz Morato <matevz.morato@gmail.com>
saching13
added a commit
that referenced
this pull request
Aug 11, 2023
* Added WIP Image Align for visualization * Working calibration with SYnc * added board config files * Updated the ar0234 res * Updated mono in json * Added Output Scale factor and removed the orientation check * Fixed the osf * Fixed capture issue with different names * updated links translation * WIP structure and vertical Stereo calibration * Fixed flashing issues * updatec req condfitions * added exception msg * removed try catch and writing board names * adding rect data * Updated rectification flash * Removed comments * Added rotation to polygons * Polygon flex (#789) * Optimization and trace levels introduced WIP * tweaked parameters and updated tracelevel * Modified the board file * added debugs * tweaked intrinsics in use * iterative method added but commented * cleanedup image sizes and better ep errors * Fixed config error * Tweaked replay * Added optional rect from projection matrix * updated depthai version * Add `-ab/--antibanding {50|60|off}` option. Implement `-fps` option * Peripheral calibration - fisheye camera model (#952) * Make sure the same points are present on all images * Use initUndistortRectifyMap from fisheye calib * Fix fiheye calibration rotated rectified image * new lines from corner to corners * update calibration handler with cameraModel * WIP vermeer * Fix fisheye calibration * Fixes for RVC3 * Add mouse trigger, save calibration, custom dataset options * Update depthai version * Add options for dataset custom path * Add an option to manually specify the number of charucos * Fixed default dataset path * Support for GRAY8 img type, fix scaling issues * Lower the threshold for synced frames * Remove the CALIB_CHECK_COND * Cleared old opencv dependencies versioning * Peripheral calibration rvc3 (#1040) * if fisheye changed the requiement to need all the corners on the board * added coverage window * added charuco cornes and coverage visualization * small improvements * added marker visualization for capture * removed merge datasets * reprojection error and cover image * removed unused name * fixed the requirements.txt * saving converge files * modified calibration parameters * added json for no vertical testing * Changes * Adding_display_option * Adding_display_option * Changes * Adding changes in parameteres * Testing on OAK-D-PRO and small changes * Change in rescale of text in combined images * Adding the combinedCoverageimages * Update on calibrate.py * Adding the submodules and calibration file * Path to depthai_calibtraion * Path to submodule * Adding output scale factor as arg * Fixing traceLvl and timesync * Changed traceLevel as argument --------- Co-authored-by: Sachin <sachin.guruswamy@gmail.com> Co-authored-by: Sachin Guruswamy <43363595+saching13@users.noreply.github.com> Co-authored-by: alex-luxonis <alex@luxonis.com> Co-authored-by: Nejc Jezeršek <njezersek@gmail.com> Co-authored-by: Matevz Morato <matevz.morato@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.