Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation doesn't mention threading rules consistently #59

Closed
PieterPenninckx opened this issue Jul 16, 2023 · 2 comments
Closed

Documentation doesn't mention threading rules consistently #59

PieterPenninckx opened this issue Jul 16, 2023 · 2 comments

Comments

@PieterPenninckx
Copy link

The LV2 documentation mentions threading rules. It appears that lilv doesn't attempt to apply thread synchronisation (it doesn't "abstract away" the threading rules as far as I can see). The documentation mentions some threading classes, but not everywhere. In particular, it's not clear from the documentation whether lilv_instance_run and lilv_instance_deactivate can be called concurrently.

@drobilla
Copy link
Collaborator

drobilla commented Aug 7, 2023

Fair enough, although these functions are just trivial (as "trivial" as can be, see the header) wrappers for the corresponding LV2 functions. It was probably a mistake to add them at all, but at the time I thought it was more friendly to have a whole API that's consistently like lilv_do_whatever() that can be used to run a plugin.

@drobilla
Copy link
Collaborator

Fixed in ecd0743, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants