Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suil 0.10.{14,16} build failure #19

Closed
chenrui333 opened this issue Aug 15, 2022 · 4 comments
Closed

suil 0.10.{14,16} build failure #19

chenrui333 opened this issue Aug 15, 2022 · 4 comments

Comments

@chenrui333
Copy link

👋 trying to build the latest release, but run into some build issue. The error log is as below:

build error
../src/qt5_in_gtk.cpp:128:36: error: use of undeclared identifier 'gtk_socket_get_id'; did you mean 'g_socket_get_fd'?
  const WId            id   = (WId)gtk_socket_get_id(s);
                                   ^~~~~~~~~~~~~~~~~
                                   g_socket_get_fd
/opt/homebrew/Cellar/glib/2.72.3/include/glib-2.0/gio/gsocket.h:85:24: note: 'g_socket_get_fd' declared here
int                    g_socket_get_fd                  (GSocket                 *socket);
                       ^
../src/qt5_in_gtk.cpp:128:54: error: cannot initialize a parameter of type 'GSocket *' (aka '_GSocket *') with an lvalue of type 'AtkSocket *const' (aka '_AtkSocket *const')
  const WId            id   = (WId)gtk_socket_get_id(s);
                                                     ^
/opt/homebrew/Cellar/glib/2.72.3/include/glib-2.0/gio/gsocket.h:85:83: note: passing argument to parameter 'socket' here
int                    g_socket_get_fd                  (GSocket                 *socket);
                                                                                  ^
7 errors generated.
ninja: build stopped: subcommand failed.

full build log, https://github.com/Homebrew/homebrew-core/runs/7709799805
relates to Homebrew/homebrew-core#107505
relates to Homebrew/homebrew-core#108065

@drobilla
Copy link
Collaborator

Failed to execute: ./waf

The build system has switched to meson.

@chenrui333
Copy link
Author

Failed to execute: ./waf

The build system has switched to meson.

yeah, I know that, see this build log, https://github.com/Homebrew/homebrew-core/runs/7832262914

@drobilla
Copy link
Collaborator

That's a different log...

In the new one, it looks like qt5_in_gtk3 doesn't build.

I see, there is a missing check for gtk3_x11_dep.found(). That wrapper doesn't, and never did, build on "pure" MacOS.

Should be fixed in ecebfdb, thanks.

@chenrui333
Copy link
Author

Should be fixed in ecebfdb, thanks.

yeah, works for me, thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants